Until President Donald Trump, few saw it as controversial.